[PATCH] D21420: Properly handle short file names on the command line in Windows

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 16:52:55 PDT 2016

amccarth added a comment.

In http://reviews.llvm.org/D21420#459506, @majnemer wrote:

> Any reason not to perform the call to `ExpandShortFileName` in `GetArgumentVector`?  I think we only need to do this for the first argument.

I was trying to be complete by treating all the arguments the same way.  Note that the existing code calls WildcardExpand on the first argument, even though that one seems really unlikely to have wildcards.  And, if it does, you need to expand wild cards before expanding the short file names.

That said, I'm open to treating the first argument as a special case if you can convince me it is indeed special.


More information about the llvm-commits mailing list