[PATCH] D21410: [pdb] Change type visitor pattern to use dynamic polymorphism

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/DebugInfo/CodeView/CVTypeVisitor.cpp:1
@@ +1,2 @@
+//===- CVTypeVisitor.cpp ----------------------------------------*- C++ -*-===//
+//
----------------
Remove `-*- C++ -*-` since this file has .cpp extnesion.

================
Comment at: lib/DebugInfo/CodeView/CVTypeVisitor.cpp:21
@@ +20,3 @@
+  Data = Data.drop_front(sizeof(*Res));
+  return Error::success();
+}
----------------
This is not directly related to this change, but should we write `return {}` instead of `return Error::success()` for the sake of brevity?


http://reviews.llvm.org/D21410