[PATCH] D21393: [pdbdump] Verify LF_{CLASS, ENUM, INTERFACE, STRUCTURE, UNION} records with different hash function.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 12:49:13 PDT 2016

zturner added a comment.

In http://reviews.llvm.org/D21393#459087, @ruiu wrote:

> Yeah, I don't think this code will live here forever. I'm adding code here to verify that my understanding on how the hash values are computed is correct. Once everything is set, I'll probably remove it from here and move this to a writer.

Ok, for the time being can you add a command line option `--verify-tpi-hash-integrity` and only do this check if it is set?  Sometimes I dump really large files, and I'm afraid this would double the amount of time it takes which is already >= 1 minute in some cases.


More information about the llvm-commits mailing list