[PATCH] D21395: Fix for Bug 28144 and print register preserved in comments in asm files

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 12:45:03 PDT 2016


mcrosier added inline comments.

================
Comment at: lib/CodeGen/RegUsageInfoCollector.cpp:124
@@ +123,3 @@
+      for (MachineOperand &MO : MI.operands()) {
+        if (MO.isRegMask()) {
+          const uint32_t *CalleeRegMask = MO.getRegMask();
----------------
  if (!MO.isRegMask())
    continue;

================
Comment at: lib/CodeGen/RegUsageInfoCollector.cpp:126
@@ +125,3 @@
+          const uint32_t *CalleeRegMask = MO.getRegMask();
+          for (unsigned index = 0; index < regMaskSize; index++)
+            RegMask[index] = RegMask[index] & CalleeRegMask[index];
----------------
Please rename index to i and pre-increment i.

  for (unsigned i = 0; i < regMaskSize; ++i)


http://reviews.llvm.org/D21395





More information about the llvm-commits mailing list