[PATCH] D21393: [pdbdump] Verify LF_{CLASS, ENUM, INTERFACE, STRUCTURE, UNION} records with different hash function.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 11:58:10 PDT 2016

zturner added a comment.

Well but empty.pdb is not generated by us.  Since now we're generating the hash, rather than just reading the hash that someone else generated I think we should write a test that verifies that a) we're using the correct hash function, and b) we're hashing the right buffers.  So I was thinking of a test that would work like the following:

1. Read type records, and the corresponding hashes out of empty.pdb
2. Use our functions to hash those records and generate hash values.
3. verify that the hash we generate is the same one that was found in the PDB file.

Similar to how you ran that test locally a week or so ago to check whether the hashes match so we know we're using it correctly, but in a test.


More information about the llvm-commits mailing list