[PATCH] D21232: Add attribute noreturn to functions that throw

Marshall Clow via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 11:14:35 PDT 2016


mclow.lists added a comment.

I think a macro would be better here; something like `LIBCPP_NORETURN_IF_NO_EXCEPTIONS` rather than putting `__attribute__((__noreturn__))` everywhere.

Besides, it makes it clear *why* these bits are being marked `noreturn`.

What do you think?


http://reviews.llvm.org/D21232





More information about the llvm-commits mailing list