[PATCH] D21387: [CFLAA] Remove non-pointer values from CFLGraph

Jia Chen via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 10:06:59 PDT 2016

grievejia added a comment.

In http://reviews.llvm.org/D21387#458889, @dberlin wrote:

> It's not clear to me why you don't, long term, end up with attributes both
>  for edges and nodes.
> For example, for edges, to support field-sensitive analysis, you will
>  either need the offset or something as an edge attribute, so you can
>  differentiate what edge to follow for a given offset.
>  (unless y'all know another way)

Edge attributes could be useful. I totally agree.

However, the semanitics of StratifiedAttr, in it current form, describes something about nodes, not edges. When CFLGraph gets translated to StratifiedSets, those "edge" attributes on CFLGraph will become "node" attributes in StratifiedSets anyway. So IMO it makes more sense to move StratifiedAttr from edges to nodes.

You are right that for field sensitivity we may need to attach certain information to edges in the future. But those information will look very different from the StratifiedAttr we have right now.


More information about the llvm-commits mailing list