[PATCH] D20807: PR27938: Don't remove valid DebugLoc in Scalarizer

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 07:16:40 PDT 2016


Looks pretty plausible/reasonable.

Any chance of a smaller test case, though? (I'd start by trying to reduce
the original source some more, if possible - beyond that /may/ be worth
hand reducing the IR to get something smaller/simpler)

On Wed, Jun 8, 2016 at 12:02 AM, Karl-Johan Karlsson via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Anyone interested in reviewing this bugfix?
>
> Regards
> / Karl-Johan Karlsson
>
>
> On 2016-05-31 12:51, Karl-Johan Karlsson wrote:
>
>> Ka-Ka created this revision.
>> Ka-Ka added a reviewer: rsandifo.
>> Ka-Ka added a subscriber: llvm-commits.
>>
>> Added checks to make sure the Scalarizer::transferMetadata() don't
>> remove valid debug location's from instructions. This is important as
>> the verifier pass require that e.g. inlinable callsites have a valid
>> debug location.
>>
>> https://llvm.org/bugs/show_bug.cgi?id=27938
>>
>>
>> http://reviews.llvm.org/D20807
>>
>> Files:
>>    lib/Transforms/Scalar/Scalarizer.cpp
>>    test/Transforms/Scalarizer/dbgloc-bug.ll
>>
>> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160615/dba3c166/attachment.html>


More information about the llvm-commits mailing list