[PATCH] D21037: Preserve DebugInfo when replacing values in DAGCombiner

James Y Knight via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 06:37:44 PDT 2016

jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D21037#450137, @dblaikie wrote:

> Also, ideally, it'd be good to find a narrower place to do
>  this - having to do it in 5 different places/ways seems like we might
>  easily be missing places (or miss them in the future)?

Given the structure of the existing code, which has 5 different Replace*Uses*With functions implemented next to each-other with a bunch of duplicate-ish code, having a call to this function from each of those -- and not needing to spread it around in other places -- seems good to me.


More information about the llvm-commits mailing list