[PATCH] D21294: ELF/AMDGPU: Add support for R_AMDGPU_REL32 relocations

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 20:24:48 PDT 2016

tstellarAMD marked 2 inline comments as done.

Comment at: ELF/Target.cpp:1440-1442
@@ -1442,3 +1439,5 @@
 RelExpr AMDGPUTargetInfo::getRelExpr(uint32_t Type, const SymbolBody &S) const {
-  llvm_unreachable("not implemented");
+  if (Type != R_AMDGPU_REL32)
+    error("do not know how to handle relocation");
+  return R_PC;
I made a slight modification to your suggestion to avoid "no return value" warnings for getRelExpr().


More information about the llvm-commits mailing list