[PATCH] D20728: AMDGPU: Disable AMDGPUPromoteAlloca pass for shader calling conventions.

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 18:23:18 PDT 2016

arsenm added a comment.

In http://reviews.llvm.org/D20728#445653, @nhaehnle wrote:

> The problem is that Mesa currently lies about which data lives in LDS, in particular for tessellation shader inputs and outputs. A proper fix would first need to take care of that.
> In general it's unclear to me how Mesa and LLVM should communicate about how LDS is used. Can we get a guarantee e.g. that LLVM-reserved LDS memory will always be placed after any LDS object in the initial IR?
> I vote to fix the current issue for now (though yes, tests sound like a good idea :)) while we figure out the LDS allocation issues.

The order allocated is the reverse use order in the function, so it could be either order. This needs to be fixed for other reasons too, but is a pain


More information about the llvm-commits mailing list