[PATCH] D21360: test-suite cmake: Detect test subdirectories when running cmake.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 16:52:52 PDT 2016

MatzeB added a comment.

In http://reviews.llvm.org/D21360#458243, @tra wrote:

> > Is it fine to search for */CMakeLists.txt on the toplevel test-suite directory?
> I don't see much point of doing that. For directories that are part of the source tree we already know they are there and can include them explicitly (assuming there are only few of them). External directories would also be explicitly specified via TEST_SUITE_SUBDIRS.
> Do you have particular use case for wildcard search?

I guess this is a matter of preference. I personally find it very convenient to simply move additional test-suites as a subdirectory of my test-suite checkout. So I can already express the list of tests I want to run simply by moving directories in and out of the test-suite checkout.

This is also similar to how the tools/ and projects/ directories in llvm work where you can drop stuff like compiler-rt, libcxx, clang etc. as you need them.

My question was more about whether we should restrict the wildcard matching to a well-known subdirectory (say 'projects' to stay in line with llvm or maybe the existing 'External' directory). Please also note that this will of course only pickup 1 level of directories and not recurse into subdirectories so it should not be a performance problem.



More information about the llvm-commits mailing list