[PATCH] D21255: Fix cloning GlobalValues with comdats across Modules.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 16:37:26 PDT 2016

jlebar added a comment.

> Something like copyComdatFrom which asserts that the source and dest are from the same module.

What are the circumstances under which one would or wouldn't want to copy the comdat, when copying all the rest of the attributes?  Like, if we should (almost) always do it, then moving it into a separate function doesn't make a lot of sense to me.  OTOH if we almost never actually want do it...


More information about the llvm-commits mailing list