[PATCH] D16829: An implementation of Swing Modulo Scheduling
Brendon Cahoon via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 14 15:05:52 PDT 2016
bcahoon updated this revision to Diff 60760.
bcahoon added a comment.
Hi Matthias - thank you for the review and the comments. I really appreciate it. I think I've addressed all of your comments, unless I've inadvertently missed something. The new patch includes a lot of changes based upon your comments. The code has also been rebased.
Here's a summary of the changes:
I decided to use the name Pipeliner to be more consistent with naming, except for the test names which still start with swp. I don't really have a strong preference of Pipeliner vs. SWP vs. SMS in the naming scheme.
I've moved the code to add the pipeliner pass to HexagonTargetMachine.cpp in the addPreRegAlloc method instead of doing it in TargetPassConfig.cpp.
I've added some more high-level comments at the beginning with references to a couple of useful papers.
I've converted many loops to be range-based for loops.
I've removed the comments from the method declarations so that they are not repeated in the method implementation.
I've removed unnecessary metadata, etc. from the tests.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 184707 bytes
Desc: not available
More information about the llvm-commits