[PATCH] D21237: LoopRotation: remove iterative calls to rotateLoops

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 12:07:26 PDT 2016

sebpop added a comment.

In http://reviews.llvm.org/D21237#457089, @atrick wrote:

> When two passes share common transformations, they should share a utility. They should not be combined into one pass unless they 
>  (a) are driven be the same analysis
>  (b) have the same pass ordering dependencies

I stand corrected: loop-rotation and jump-thread should remain in separate passes.

Maybe we can improve the current code by using the same code generation functionality:
I see that currently there is no function to duplicate a single entry multiple exits (SEME) path
needed for both loop-rotation and jump-threading.


More information about the llvm-commits mailing list