[PATCH] D20348: IR: Introduce local_unnamed_addr attribute.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 11:43:03 PDT 2016

chandlerc added a comment.

In http://reviews.llvm.org/D20348#455417, @rafael wrote:

> This LGTM.
> Chandler, are you OK with this being an attribute given Mehdi's argument that "llvm-dis | llvm-as" should produce equivalent bitcode?

Yea, I guess.

I completely buy the argument that llvm-dis | llvm-as should produce equivalent bitcode. =] That's not my hang-up. I just think we will regret having both 'unnamed_addr' and 'local_unnamed_addr' with such subtly different semantics, and I continue to find the approach we are taking to address problems here to feel like a mis-use of the attribute system. This just doesn't feel like it fits.

But that said, I don't have an alternative suggestion at this point, and I don't want to obstruct progress. I just predict us having to walk this back at some future date and that being costly, which makes it hard for me to be super enthusiastic. Ahh, well.


More information about the llvm-commits mailing list