[PATCH] D12965: [InstCombine] shrink switch conditions better (PR24766)

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 10:48:21 PDT 2016

spatel added a comment.

In http://reviews.llvm.org/D12965#457658, @majnemer wrote:

> Hmm.  My understanding was that InstCombine was not supposed to create IR with illegal types if it could help it.

Do we state that anywhere? Should we make an exception for cases where we know that we have a fixup in a later pass (as we do for this in CGP)?

I was proceeding based on Hal's earlier comment:
"We should shrink aggressively for our canonical form because smaller types convey the most information at the IR level."


More information about the llvm-commits mailing list