[PATCH] D21321: [mips] Optimize stack pointer adjustments.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 05:34:18 PDT 2016

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with one more nit.

Comment at: test/CodeGen/Mips/cstmaterialization/stack.ll:30-32
@@ +29,5 @@
+; These are here to match other lui's used in offset computations and they're
+; also duplicated.
Thanks. In that case, can we phrase the comment in terms of an action to take in the future (e.g. 'fix the duplicated address generation').


More information about the llvm-commits mailing list