[PATCH] D21146: Fix BSS global handling in AsmPrinter

[Rafael Espíndola via llvm-commits]

Lgtm. Do you have commit access?

BTW, I don't think there is any value in using a .lcomm or a .local/.comm
pair instead of . section. A followup patch changing that also lgtm :-)

Cheers,
Rafael
On Jun 8, 2016 2:15 PM, "Nirav Dave" <niravd at google.com> wrote:

niravd created this revision.
niravd added reviewers: echristo, rafael.
niravd added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini.

Change EmitGlobalVariable to check final assembler section is in BSS
before using .lcomm/.comm directive. This prevents globals from being
put into .bss erroneously when -data-sections is used.

This fixes PR26570.

http://reviews.llvm.org/D21146

Files:
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  test/CodeGen/X86/global-sections.ll
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160614/4c1c988a/attachment.html>