[PATCH] D21316: Remove the ScalarReplAggregates pass

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 00:30:48 PDT 2016


chandlerc added a subscriber: chandlerc.
chandlerc accepted this revision.
chandlerc added a reviewer: chandlerc.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM. I'm a bit sad to not kill this myself, but you should just kill it with fire while you're here. You've done the hard deletion work. I'm glad to see it go now that there is no real reason to keep it around.

(And FWIW, the two things that held it around for this long were the C API and before SROA switched to always use the DomTree some hypothetical concerns about compile time impact of the SSAUpdater path with the new SROA being worse than with ScalarRepl. The latter has been obviated, and the former seems well addressed here and with the C-API policy changes.)


http://reviews.llvm.org/D21316





More information about the llvm-commits mailing list