[PATCH] D21276: [AArch64]Make getDefaultExtensions to return exactly what we want.

jojo.ma via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 23:54:48 PDT 2016

jojo added a comment.

Sorry that I should have introduced the background:

As Renato said above.This change is required to reapply D21277 <http://reviews.llvm.org/D21277>(the original review is D20088 <http://reviews.llvm.org/D20088>), which failed in some buildbots as some different configurations.

I built almost a same envionment as the buildbot on my local.After some debugging,I found we would get different result here, before and after the using of "-std=c++11" 
and the latter is not what we expect(I'm not familiar with "c++11" so I don't know why.) . And this will cause us to add incorrect features to the feature list(not a order problem as we thought)
,finally fail the regression.

Actually,ORing the base extensions is not necessary in this TargetParser if we look through the code. So,I remove  it here,just let it return what we want.

Thank you for your review!

Best Regards,



More information about the llvm-commits mailing list