[PATCH] D21316: Remove the ScalarReplAggregates pass

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 20:22:44 PDT 2016

majnemer added a comment.

In http://reviews.llvm.org/D21316#457156, @silvas wrote:

> Does SROA pass all the test cases for ScalarRepl? I remember when Davide was looking at IPCP vs IPSCCP (with IPCP seeming to be dead) that there were actually some cases missed by IPSCCP and so IPCP wasn't deleted.

A partial survey indicates that SROA does all that ScalarRepl can do. Some ScalarRepl tests which fail are grep based and thus sensitive to the exact IR produced by the pass, others fail because SROA produces IR with fewer bitcasts (ScalarRepl produces stuff like `trunc i160 undef to i32`).

In any case, it's pretty moot: nobody uses ScalarRepl which makes it effectively dead.


More information about the llvm-commits mailing list