[PATCH] D21311: LoopRotate: restructure code to simplify functions

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 15:29:32 PDT 2016

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with nits

Comment at: llvm/lib/Transforms/Scalar/LoopRotation.cpp:54
@@ +53,3 @@
+class LoopRotate {
+  unsigned MaxHeaderSize;
+  LoopInfo *LI;
How about `const unsigned MaxHeaderSize`?

Comment at: llvm/lib/Transforms/Scalar/LoopRotation.cpp:68
@@ +67,3 @@
+  bool processLoop(Loop *L);
+  bool rotateLoop(Loop *L, bool SimplifiedLatch);
Looks like only the constructor and `processLoop` need to be public?


More information about the llvm-commits mailing list