[PATCH] D21154: AMDGPU/SI: Refactor fixup handling for constant addrspace variables

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 11:10:45 PDT 2016

arsenm added inline comments.

Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:1424
@@ +1423,3 @@
+  const GlobalValue *GV = GSD->getGlobal();
+  MVT PtrVT = getPointerTy(DAG.getDataLayout(), GSD->getAddressSpace());
I think it's better to just re-use the existing Op.getValueType()


More information about the llvm-commits mailing list