[PATCH] D21276: [AArch64]Make getDefaultExtensions to return exactly what we want.

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 09:26:04 PDT 2016

rengolin added a comment.

So, a bit more context...

This change is required to reapply http://reviews.llvm.org/D21277, which failed in some buildbots but not on our local tests. The error was due to the order in which target features were selected by Clang:

- some targets had "-target-feature" "-foo" "-target-feature" "-bar"
- others had "-target-feature" "-bar" "-target-feature" "-foo"

The problem ended up being how we select the flags and, as Saleem suggested, made them unique. Jojo can clarify on a comment later.

I believe this change should be squashed to http://reviews.llvm.org/D21277 and committed as one, but it was good that Jojo made two reviews, so we can discuss them separately.

The other patch is just a copy / rebase of the old one, so there should be no concerns there.




More information about the llvm-commits mailing list