[PATCH] D20418: [mips] MIPS32/64 itineraries

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 03:20:27 PDT 2016

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a variable naming nit in the tests.

Comment at: test/CodeGen/Mips/cmov.ll:524-531
@@ -523,10 +523,10 @@
-; 64-CMP-DAG:  daddiu $[[I5:[0-9]+]], $zero, 5
-; 64-CMP-DAG:  daddiu $[[I4:2]], $zero, 4
+; 64-CMP-DAG:  daddiu $[[I5:[0-9]+]], $zero, 4
+; 64-CMP-DAG:  daddiu $[[I4:2]], $zero, 5
 ; 64-CMP-DAG:  daddiu $[[R1:[0-9]+]], ${{[0-9]+}}, 32766
 ; 64-CMP-DAG:  slt $[[R0:[0-9]+]], $[[R1]], $4
 ; FIXME: We can do better than this by using selccz to choose between -0 and -2
-; 64-CMP-DAG:  selnez $[[T0:[0-9]+]], $[[I5]], $[[R0]]
-; 64-CMP-DAG:  seleqz $[[T1:[0-9]+]], $[[I4]], $[[R0]]
-; 64-CMP-DAG:  or $2, $[[T0]], $[[T1]]
+; 64-CMP-DAG:  seleqz $[[T0:[0-9]+]], $[[I5]], $[[R0]]
+; 64-CMP-DAG:  selnez $[[T1:[0-9]+]], $[[I4]], $[[R0]]
+; 64-CMP-DAG:  or $2, $[[T1]], $[[T0]]
I4 and I5 were named because they contained the values 4 and 5 respectively. Could you change this so that this is still the case?


More information about the llvm-commits mailing list