[PATCH] D21254: [asan] Do not instrument pointers with address space attributes

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 02:03:58 PDT 2016


kubabrecka added inline comments.

================
Comment at: test/Instrumentation/ThreadSanitizer/tsan_address_space_attr.ll:32
@@ +31,2 @@
+}
+; CHECK-NOT: addrspacecast
----------------
kubabrecka wrote:
> Can we check for the presence of the instrumentation call instead?  The presence or non-presence of “addrspacecast” is a secondary thing.
(or CHECK-NOT for both if the previous code inserted an invalid addrspacecast)


http://reviews.llvm.org/D21254





More information about the llvm-commits mailing list