[PATCH] D20896: [LLVM][MIPS] Introduce a CheckAtomic64 cmake module.

Nitesh Jain via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 01:29:14 PDT 2016


nitesh.jain added a comment.

In http://reviews.llvm.org/D20896#454788, @zturner wrote:

> My own comments:
>
> This looks fine since it removes code duplication across multiple
>  subprojects. Have you tested that both libcxx and lldb work correctly when
>  using this module as opposed to the existing ones?


I  have check lldb work correctly with this module.

In http://reviews.llvm.org/D20896#454788, @zturner wrote:

> My own comments:
>
> This looks fine since it removes code duplication across multiple
>  subprojects. Have you tested that both libcxx and lldb work correctly when
>  using this module as opposed to the existing ones?


This module work fine with LLDB but need to check with libcxx. I will check and let you know.


Repository:
  rL LLVM

http://reviews.llvm.org/D20896





More information about the llvm-commits mailing list