[polly] r270410 - Make the detection context non-constant [NFC]

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 11 02:36:18 PDT 2016


On Wed, Jun 8, 2016, at 11:01 AM, Johannes Doerfert via llvm-commits
wrote:
> On 06/07, Tobias Grosser wrote:
> > On 05/23/2016 11:07 AM, Johannes Doerfert via llvm-commits wrote:
> > > Author: jdoerfert
> > > Date: Mon May 23 04:07:08 2016
> > > New Revision: 270410
> > > 
> > > URL: http://llvm.org/viewvc/llvm-project?rev=270410&view=rev
> > > Log:
> > > Make the detection context non-constant [NFC]
> > 
> > Hi Johannes,
> > 
> > I personally don't have a strong opinion on this, but I also don't see
> > why the non-const version is preferable. Could you enlighten me?
> Because you want small commits and it was needed for the [FIX] d7d367d39
> that did crash the code generation otherwise

Thanks for the explanation. 

It would be helpful for post-commit reviews to add such motivations in
future commit messages.

Best,
Tobias


More information about the llvm-commits mailing list