[polly] r271534 - [FIX] Correctly translate i1 expressions

[Tobias Grosser via llvm-commits]

On Wed, Jun 8, 2016, at 11:15 AM, Johannes Doerfert via llvm-commits
wrote:
> On 06/07, Tobias Grosser wrote:
> > On 06/02/2016 06:57 PM, Johannes Doerfert via llvm-commits wrote:
> > > Author: jdoerfert
> > > Date: Thu Jun  2 11:57:12 2016
> > > New Revision: 271534
> > > 
> > > URL: http://llvm.org/viewvc/llvm-project?rev=271534&view=rev
> > > Log:
> > > [FIX] Correctly translate i1 expressions
> > 
> > Hi Johannes,
> > 
> > without any further context it is difficult to understand what the
> > actual issue here was and how this commit resolves this problem.
> > 
> > You have done great work in adding unsigned support to Polly -- most of
> > this without pre-commit review. In general this is good as it allows us
> > to be agile in our development, but this also means we miss an
> > opportunity to learn about your implementation. Commit messages can be a
> > great way to teach people about your code.
> > 
> > Could you possibly give a brief explanation _what_ the actual issue was
> > and _how_ it has been resolved?
> Issue:
>   i1 does not include the neutral element for multiplication but that
>   is expected by the extractConstantFactor function.
> Solution:
>   Do not use the factor extracted by extractConstantFactor for i1 types.

Alright. This is probably worth a comment in the source code. Would you
mind adding such a comment?

Best,
Tobias