[PATCH] D21236: AMDGPU/SI: Correctly encode constant expressions

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 18:04:15 PDT 2016


tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp:168
@@ +167,3 @@
+  if (MO.isExpr()) {
+    const MCConstantExpr *C = dyn_cast<MCConstantExpr>(MO.getExpr());
+    if (!C)
----------------
artem.tamazov wrote:
> BTW, is it possible to use MCExpr::evaluateAsAbsolute() to to get a "constant" (i.e. known during assembly time) value?
Maybe, I will look into this and do a follow on patch.


http://reviews.llvm.org/D21236





More information about the llvm-commits mailing list