[PATCH] D21237: LoopRotation: remove iterative calls to rotateLoops

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 14:20:18 PDT 2016


sebpop added a comment.

Thanks for your patch: it looks similar, so you have one more LGTM ;-)
Could you please commit?

In http://reviews.llvm.org/D21237#455028, @mzolotukhin wrote:

> @sebpop: it's interesting, I'm working on that too actually. How do you plan to handle that and how far have you progressed with it? I hope to get something working soonish.


We haven't got very far: we just have seen this oddity today.
We were also thinking to remove the corner cases of code hoisting from loop rotation (it is not the place to do these cleanups.)
And then we would simplify the code copying with a plain BB->copy().
We need to keep copying BBs as far as we have not reached the loop latch and still under some budget in terms of number of copied instructions.


http://reviews.llvm.org/D21237





More information about the llvm-commits mailing list