[llvm] r272430 - [AArch64] Move comments closer to relevant check. NFC.

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 13:49:18 PDT 2016


Author: mcrosier
Date: Fri Jun 10 15:49:18 2016
New Revision: 272430

URL: http://llvm.org/viewvc/llvm-project?rev=272430&view=rev
Log:
[AArch64] Move comments closer to relevant check. NFC.

Modified:
    llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp

Modified: llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp?rev=272430&r1=272429&r2=272430&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp Fri Jun 10 15:49:18 2016
@@ -1247,10 +1247,6 @@ AArch64LoadStoreOpt::findMatchingInsn(Ma
       // check for +1/-1. Make sure to check the new instruction offset is
       // actually an immediate and not a symbolic reference destined for
       // a relocation.
-      //
-      // Pairwise instructions have a 7-bit signed offset field. Single insns
-      // have a 12-bit unsigned offset field. To be a valid combine, the
-      // final offset must be in range.
       unsigned MIBaseReg = getLdStBaseOp(MI).getReg();
       int MIOffset = getLdStOffsetOp(MI).getImm();
       bool MIIsUnscaled = TII->isUnscaledLdSt(MI);
@@ -1285,8 +1281,10 @@ AArch64LoadStoreOpt::findMatchingInsn(Ma
             continue;
           }
         } else {
-          // If the resultant immediate offset of merging these instructions
-          // is out of range for a pairwise instruction, bail and keep looking.
+          // Pairwise instructions have a 7-bit signed offset field. Single
+          // insns have a 12-bit unsigned offset field.  If the resultant
+          // immediate offset of merging these instructions is out of range for
+          // a pairwise instruction, bail and keep looking.
           if (!inBoundsForPair(IsUnscaled, MinOffset, OffsetStride)) {
             trackRegDefsUses(MI, ModifiedRegs, UsedRegs, TRI);
             MemInsns.push_back(MI);




More information about the llvm-commits mailing list