[PATCH] D20639: SLPVectorizer: Move propagateMetadata to VectorUtils

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 13:17:10 PDT 2016


jlebar added a subscriber: jlebar.

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:676
@@ -698,2 +675,3 @@
+                                      Instruction *From) {
   propagateMetadata(To, From);
   addNewMetadata(To, From);
----------------
mzolotukhin wrote:
> Hmm.. `propagateMetadata` expects `ArrayRef<Value *> VL` now instead of `Instruction *From`, doesn't it? Am I missing something?
ArrayRef has a one-element constructor (strangely enough).  http://llvm.org/docs/doxygen/html/classllvm_1_1ArrayRef.html#a3b1f44186f9787d7ffacb54b62d6798c

Something does seem to be wrong here, though; the assertion failures I mentioned in http://reviews.llvm.org/D19501#454941 seem to be coming from this patch.  Not sure why yet.


http://reviews.llvm.org/D20639





More information about the llvm-commits mailing list