[PATCH] D21180: [IPRA] Interprocedural Register Allocation - Transformation Pass

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 09:54:25 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/CodeGen/RegUsageInfoPropagate.cpp:110
@@ +109,3 @@
+        const auto *RegMask = PRUI->getRegUsageInfo(F);
+        if (RegMask) { // else skip optimization
+          setRegMask(MI, &(*RegMask)[0]);
----------------
```
if (!RegMask)
  return;
```

================
Comment at: lib/CodeGen/RegUsageInfoPropagate.cpp:119
@@ +118,3 @@
+        UpdateRegMask((Function *)Operand.getGlobal());
+      else if (Operand.isSymbol())
+        UpdateRegMask(M->getFunction(Operand.getSymbolName()));
----------------
No unsafe C-like cast, use the llvm style of casting please: `cast<Function>`


http://reviews.llvm.org/D21180





More information about the llvm-commits mailing list