[PATCH] D20896: [LLVM][MIPS] Introduce a CheckAtomic64 cmake module.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 09:17:15 PDT 2016


My own comments:

This looks fine since it removes code duplication across multiple
subprojects. Have you tested that both libcxx and lldb work correctly when
using this module as opposed to the existing ones?
On Fri, Jun 10, 2016 at 2:15 AM Nitesh Jain <nitesh.jain at imgtec.com> wrote:

> nitesh.jain added a comment.
>
> Hi Chandler Carruth,
>
> Please could you find some time to review this ?
>
> Thanks
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D20896
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160610/bed4ad77/attachment.html>


More information about the llvm-commits mailing list