[PATCH] D21222: Double size of sigaltstack to prevent overflow

Jonas Hahnfeld via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 00:54:26 PDT 2016


Hahnfeld created this revision.
Hahnfeld added a reviewer: rsmith.
Hahnfeld added a subscriber: llvm-commits.

On a crash `printSymbolizedStackTrace(...)` would need more memory than currently
allocated and therefore corrupts some data in front of sigaltstack.

http://reviews.llvm.org/D21222

Files:
  lib/Support/Unix/Signals.inc

Index: lib/Support/Unix/Signals.inc
===================================================================
--- lib/Support/Unix/Signals.inc
+++ lib/Support/Unix/Signals.inc
@@ -127,7 +127,7 @@
 static stack_t OldAltStack;
 
 static void CreateSigAltStack() {
-  const size_t AltStackSize = MINSIGSTKSZ + 8192;
+  const size_t AltStackSize = MINSIGSTKSZ + 16384;
 
   // If we're executing on the alternate stack, or we already have an alternate
   // signal stack that we're happy with, there's nothing for us to do. Don't


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21222.60318.patch
Type: text/x-patch
Size: 520 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160610/4b69050c/attachment.bin>


More information about the llvm-commits mailing list