[PATCH] D21213: [libcxx] Add possibility to link with libunwind

Eugene Zelenko via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 16:44:06 PDT 2016


Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: EricWF, mclow.lists.
Eugene.Zelenko added a subscriber: llvm-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.

LIBCXX_USE_LLVM_UNWINDER should be also used in test/lit.site.cfg.in, but somehow I got next error during regressions when it was set to ON.

lit.py: config.py:90: fatal: parameter 'llvm_unwinder' should be true or false

Regressions on RHEL 6 were OK.


Repository:
  rL LLVM

http://reviews.llvm.org/D21213

Files:
  CMakeLists.txt
  cmake/config-ix.cmake
  lib/CMakeLists.txt

Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -107,7 +107,7 @@
 
 # Build libc++abi with libunwind. We need this option to determine whether to
 # link with libunwind or libgcc_s while running the test cases.
-option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." OFF)
+option(LIBCXX_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." OFF)
 
 # Target options --------------------------------------------------------------
 option(LIBCXX_BUILD_32_BITS "Build 32 bit libc++." ${LLVM_BUILD_32_BITS})
Index: lib/CMakeLists.txt
===================================================================
--- lib/CMakeLists.txt
+++ lib/CMakeLists.txt
@@ -80,6 +80,7 @@
 add_library_flags_if(LIBCXX_HAS_RT_LIB rt)
 add_library_flags_if(LIBCXX_HAS_GCC_S_LIB gcc_s)
 add_library_flags_if(LIBCXX_HAS_ATOMIC_LIB atomic)
+add_library_flags_if(LIBCXX_USE_LLVM_UNWINDER unwind)
 
 # Setup flags.
 add_flags_if_supported(-fPIC)
Index: cmake/config-ix.cmake
===================================================================
--- cmake/config-ix.cmake
+++ cmake/config-ix.cmake
@@ -17,4 +17,6 @@
 check_library_exists(c fopen "" LIBCXX_HAS_C_LIB)
 check_library_exists(m ccos "" LIBCXX_HAS_M_LIB)
 check_library_exists(rt clock_gettime "" LIBCXX_HAS_RT_LIB)
-check_library_exists(gcc_s __gcc_personality_v0 "" LIBCXX_HAS_GCC_S_LIB)
+if (NOT LIBCXX_USE_LLVM_UNWINDER)
+  check_library_exists(gcc_s __gcc_personality_v0 "" LIBCXX_HAS_GCC_S_LIB)
+endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21213.60278.patch
Type: text/x-patch
Size: 1532 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160609/98a2ff54/attachment.bin>


More information about the llvm-commits mailing list