[PATCH] D21207: Make sure that not interesting allocas are not instrumented.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 16:19:15 PDT 2016


kcc added inline comments.

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1994
@@ +1993,3 @@
+    // All interesting allocas are either in DynamicAllocaVec or AllocaVec.
+    assert(std::find(DynamicAllocaVec.begin(), DynamicAllocaVec.end(),
+                     APC.AI) != DynamicAllocaVec.end() ||
----------------
std::find inside assert may potentially make the assert build much slower than a non-assert. 
I'd prefer if we could avoid it. 


http://reviews.llvm.org/D21207





More information about the llvm-commits mailing list