[PATCH] D21110: [CFLAA] Add yet another StratifiedAttr

[Jia Chen via llvm-commits]

grievejia marked 3 inline comments as done.

================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:1024
@@ +1023,3 @@
+      // TODO: do we need to filter out non-pointer values here?
+      Builder.addAttributesBelow(&Val, AttrUnknown);
+    }
----------------
george.burgess.iv wrote:
> If there's no set below `Val` when calling `addAttributesBelow`, do we need to create one just to tag it with attributes? If not, maybe we could add a `forceCreation` flag (that defaults to true) or something?
If we don't create it, and if another node is put there (either through insertion or through merge) some time later, how can we make sure that the newly created node is tagged AttrUnkown?

================
Comment at: test/Analysis/CFLAliasAnalysis/attr-escape.ll:6
@@ -5,5 +5,3 @@
 
-; CHECK: Function: escape_ptrtoint
-; CHECK: NoAlias: i32* %a, i32* %x
-; CHECK: NoAlias: i32* %b, i32* %x
+; CHECK: Function: test_local
 ; CHECK: NoAlias: i32* %a, i32* %b
----------------
george.burgess.iv wrote:
> Nit that I should've caught earlier: CHECK-LABEL should be used for functions. This lets FileCheck check the remainder of functions in the file if there's a problem with this one (for whatever reason).
All existing tests under test/Analysis/CFLAliasAnalysis/ use "CHECK". That's why I followed this "convention"...


http://reviews.llvm.org/D21110