[PATCH] D21157: [pdb] Improve StreamInterface to support writing

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/DebugInfo/PDB/Raw/MappedBlockStream.cpp:47-48
@@ -46,3 +46,4 @@
 
   auto CacheIter = CacheMap.find(Offset);
   if (CacheIter != CacheMap.end()) {
+    // Try to find an alloc that was large enough for this request.
----------------
Doesn't this mean that larger queries that happened earlier are not reused?

Let's say we start with an empty cache.
Then a read request for 4096 bytes from offset 0 happens.
Then a read request for 1024 bytes at offset 1024 happens.
Won't the second request not share with the first?


http://reviews.llvm.org/D21157