[PATCH] D20769: [IPRA] Interprocedural Register Allocation - Analysis Passes

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 09:03:09 PDT 2016


mehdi_amini added inline comments.

================
Comment at: include/llvm/CodeGen/RegisterUsageInfo.h:58-59
@@ +57,4 @@
+
+  const std::vector<uint32_t> *getRegUsageInfo(const Function *FP);
+
+  void print(raw_ostream &OS, const Module *M = nullptr) const override;
----------------
Doxygen the two public API above.

================
Comment at: lib/CodeGen/RegUsageInfoCollector.cpp:79
@@ +78,3 @@
+    RegMask[*AI / 32] &= ~(1u << *AI % 32);
+  }
+}
----------------
No braces

================
Comment at: lib/CodeGen/RegisterUsageInfo.cpp:72
@@ +71,3 @@
+    FPRMPairVector.push_back(&RegMask);
+  }
+
----------------
No braces.

================
Comment at: lib/CodeGen/TargetPassConfig.cpp:504
@@ +503,3 @@
+    addPass(new DummyCGSCCPass);
+  }
+
----------------
No braces

================
Comment at: lib/CodeGen/TargetPassConfig.cpp:632
@@ -616,1 +631,3 @@
+  }
+
   addPass(&FuncletLayoutID, false);
----------------
No braces


http://reviews.llvm.org/D20769





More information about the llvm-commits mailing list