[PATCH] D21182: [AArch64] Restore codegen for AArch64 Cortex-A72/A73 after NFCI

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 08:57:28 PDT 2016


rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D21182#453431, @sbaranga wrote:

> bin/llc ../llvm/test/Transforms/InstCombine/phi-preserve-ir-flags.ll  -o - -mtriple=aarch64-linux-gnueabi -mattr=+merge-narrow-ld
>  bin/llc ../llvm/test/Transforms/InstCombine/phi-preserve-ir-flags.ll  -o - -mtriple=aarch64-linux-gnueabi -mattr=-merge-narrow-ld


right, and if we already have those, then putting features into CPU descriptions don't need any additional test. It's also not going to regress, because we only do the migration once, and all future changes will be regarding features, not CPU names.

LGTM, assuming we already have all the necessary tests in place.


http://reviews.llvm.org/D21182





More information about the llvm-commits mailing list