[PATCH] D21155: [SystemZ] Support Compare and Traps

[Ulrich Weigand via llvm-commits]

uweigand added a comment.

Thanks to koriakin for the review, I agree with the points raised there.

One additional question: why is the splitBlockAfter in emitTrap needed?   I notice that other platforms don't seem to require similar code when emitting a trap.  Shouldn't marking the trap as isTerminator in the .td file cause common code to terminate the basic block already?

Also, LLVM coding style limits line length to 80 characters, which your patch currently exceed in some places.


http://reviews.llvm.org/D21155