[llvm] r272241 - AArch64: support the `.arch` directive in the IAS

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 06:57:47 PDT 2016


On 9 June 2016 at 03:56, Saleem Abdulrasool via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: compnerd
> Date: Wed Jun  8 21:56:40 2016
> New Revision: 272241
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272241&view=rev
> Log:
> AArch64: support the `.arch` directive in the IAS
>
> Add support to the AArch64 IAS for the `.arch` directive.  This allows the
> assembly input to use architectural functionality in part of a file.  This is
> used in existing code like BoringSSL.

Hi Saleem,

Just a comment, it would be good to separate the good tests from the
negative tests.

We just found a number of llc negative tests that were "passing"
because of an unrelated assert, not because they were actually hitting
the expected error message. We don't want *all* .arch tests to "pass"
because of problems like that. :)

cheers,
--renato


More information about the llvm-commits mailing list