[PATCH] D20560: [new PM] port LoopAccessAnalysis to new pass manager (part-1)
Chandler Carruth via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 8 18:32:47 PDT 2016
On Wed, Jun 8, 2016 at 6:29 PM Xinliang David Li <xinliangli at gmail.com>
> On Wed, Jun 8, 2016 at 6:09 PM, Chandler Carruth via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>> chandlerc added a comment.
>> At a meta level, if I've started reviewing a patch, please wait until I
>> have a chance to see your updates before submitting it. I'm sorry I didn't
>> get to it in the early morning, but its still well under 24h turn around
>> and I don't know that its reasonable to expect lower latency.
>> That's not to say that I don't appreciate all of Adam and Davide's
>> comments -- they're help reviewing is much appreciated -- but as it happens
>> I don't actually think this is the right approach.
> Ah -- you had initial comments saying this makes sense -- thus I assumed
> it is fine with lgtm.
Sorry if I gave the wrong impression. =] At that point, I thought it did
make sense, but I hadn't yet understood the nature of what LoopAccessInfo
was doing. As it was cleaned up, it became much more clear.
> What you said below makes sense. I will rework on the patch to use
> LoopAnalysisManager to see if works.
Yea, understand that this is a less well exercised part of the pass
manager. I've essentially been going bottom-up to parallelize with other
efforts. So you may run into some issues. Feel free to chat and get help if
having trouble with the per-loop structuring of things.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits