[PATCH] D20988: [cpu-detection] Substantial refactor of Host CPU detection code (x86)
Alina Sbirlea via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 8 17:08:34 PDT 2016
asbirlea added inline comments.
================
Comment at: llvm/trunk/lib/Support/Host.cpp:659
@@ +658,3 @@
+ default:
+ break;
+ }
----------------
sanjoy wrote:
> I think there is a bug here. The `break;` will only break out of the inner switch, and for an unknown model of `"amdfam10"`, we'll set the type to `AMDFAM14H`.
Agreed.
Created: http://reviews.llvm.org/D21158
Let me know if replacing break with return is preferred.
Repository:
rL LLVM
http://reviews.llvm.org/D20988
More information about the llvm-commits
mailing list