[PATCH] D21110: [CFLAA] Add yet another StratifiedAttr

Jia Chen via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 16:39:03 PDT 2016


grievejia added a comment.

In http://reviews.llvm.org/D21110#452905, @george.burgess.iv wrote:

> A more interesting approach may be basically flipping this patch upside
>  down: only use AttrArg/AttrGlobal when we have an assign edge to
>  args/globals, and put AttrUnknown on the sets under the ones marked with
>  AttrArg/AttrGlobal. Obviously, that would only be useful if we think
>  differentiating between args/globals would be useful. If we don't think
>  this, then I'm happy to accept this patch with the removal of
>  Attr{Arg,Global}.


I (mistakenly) thought AttrGlobal/Arg was mainly motivated by the loads from globals/args, not the values. Now that you've explained your thoughts and I have a better understanding, I think your plan is definitely superior :)


http://reviews.llvm.org/D21110





More information about the llvm-commits mailing list