[PATCH] D21079: [esan|cfrag] Disable load/store/memintrinsic instrumentation for cfrag

[Qin Zhao via llvm-commits]

zhaoqin added inline comments.

================
Comment at: include/llvm/Transforms/Instrumentation.h:131
@@ -128,1 +130,3 @@
   } ToolType;
+  bool InstrumentFastpath;
+  bool InstrumentLoadsAndStores;
----------------
bruening wrote:
> This doesn't make sense to me: why expose these here ina public header when they are internal to the instrumentation pass?  Having them just be opt options as they were originally seems the better way to go.  We want cl::opt options whose defaults vary according to the tool selected.  What is needed is for cl::opt to provide a flag indicating whether the option was specified by the user or not, or else to provide more dynamic defaults, or to go with the original CL.
Would an internal option struct works?


http://reviews.llvm.org/D21079