[PATCH] D21142: [PDB] Move PDB functions to a separate file.

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 10:25:21 PDT 2016


majnemer added a subscriber: majnemer.

================
Comment at: lib/DebugInfo/PDB/Raw/Hash.cpp:21
@@ +20,3 @@
+  uint32_t Result = 0;
+  uint32_t Size = Str.size();
+
----------------
size_t ?

================
Comment at: lib/DebugInfo/PDB/Raw/Hash.cpp:30
@@ +29,3 @@
+  const uint8_t *Remainder = reinterpret_cast<const uint8_t *>(Longs.end());
+  uint32_t RemainderSize = Size - Longs.size() * 4;
+
----------------
Isn't this just `Size % 4`?


http://reviews.llvm.org/D21142





More information about the llvm-commits mailing list